From 027b8f9b4685bb22e7d750003d9645cbfacef257 Mon Sep 17 00:00:00 2001 From: lilydjwg Date: Wed, 26 Aug 2020 20:18:08 +0800 Subject: [PATCH] write versions to record files even it's up-to-date. This matches the old behavior, and the record file means what we get, not what are updated (that's what nvcmp does). --- nvchecker/core.py | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/nvchecker/core.py b/nvchecker/core.py index c1ff1d1..9666001 100644 --- a/nvchecker/core.py +++ b/nvchecker/core.py @@ -310,14 +310,12 @@ def _process_result(r: RawResult) -> Optional[Result]: def check_version_update( oldvers: VersData, name: str, version: str, -) -> Optional[str]: +) -> None: oldver = oldvers.get(name, None) if not oldver or oldver != version: logger.info('updated', name=name, version=version, old_version=oldver) - return version else: logger.debug('up-to-date', name=name, version=version) - return None async def process_result( oldvers: VersData, @@ -330,10 +328,8 @@ async def process_result( r1 = _process_result(r) if r1 is None: continue - v = check_version_update( - oldvers, r1.name, r1.version) - if v is not None: - ret[r1.name] = v + check_version_update(oldvers, r1.name, r1.version) + ret[r1.name] = r1.version except asyncio.CancelledError: return ret