From de0a5fe02e864355ed862f72d918afc7fb5e7ef8 Mon Sep 17 00:00:00 2001 From: lilydjwg Date: Mon, 1 Feb 2021 17:58:14 +0800 Subject: [PATCH] github actions: omit pypy tests continue-on-error doesn't work as expected and there is no way to "allow-failure". See https://github.com/actions/toolkit/issues/399. --- .github/workflows/tests.yaml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml index 5e2610d..5ba1d63 100644 --- a/.github/workflows/tests.yaml +++ b/.github/workflows/tests.yaml @@ -3,7 +3,6 @@ on: [push, pull_request] jobs: tests: runs-on: ubuntu-latest - continue-on-error: ${{ contains(matrix.python-version, 'pypy') }} strategy: fail-fast: false matrix: @@ -11,7 +10,11 @@ jobs: - "3.7" - "3.8" - "3.9" - - pypy-3.7 + # pypy fails in some cases but we don't care much about that + # with github actions we can't mark some jobs to not affect the overall + # conclusion so we have to omit "allow-failure" tests. + # See https://github.com/actions/toolkit/issues/399 + # - pypy-3.7 deps: - tornado pycurl - aiohttp