diff --git a/nvchecker/source/github.py b/nvchecker/source/github.py index c0c321b..3a78aa9 100644 --- a/nvchecker/source/github.py +++ b/nvchecker/source/github.py @@ -110,9 +110,10 @@ async def max_tag( else: url = next_page_url - logger.error('No tag found in upstream repository.', - name=name, - include_tags_pattern=include_tags_pattern) + if not tags: + logger.error('No tag found in upstream repository.', + name=name, + include_tags_pattern=include_tags_pattern) return tags def get_next_page_url(links): diff --git a/tests/conftest.py b/tests/conftest.py index 6580f2f..9f6831e 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -59,10 +59,12 @@ def event_loop(request): loop = asyncio.get_event_loop() yield loop -@pytest.fixture(scope="module") +@pytest.fixture(scope="session", autouse=True) def raise_on_logger_msg(): def proc(logger, method_name, event_dict): if method_name in ('warn', 'error'): + if 'exc_info' in event_dict: + raise event_dict['exc_info'] raise RuntimeError(event_dict['event']) return event_dict['event'] diff --git a/tests/test_regex.py b/tests/test_regex.py index 9a60040..5ffd50f 100644 --- a/tests/test_regex.py +++ b/tests/test_regex.py @@ -19,7 +19,7 @@ async def test_regex(get_version): "regex": 'for (\w+) examples', }) == "illustrative" -async def test_missing_ok(get_version, raise_on_logger_msg): +async def test_missing_ok(get_version): assert await get_version("example", { "url": "http://example.net/", "regex": "foobar",